Skip to content

Enable hermesV1Enabled=true by default on Android #55040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cortinico wants to merge 3 commits into from
Closed

Enable hermesV1Enabled=true by default on Android #55040

cortinico wants to merge 3 commits into from

Conversation

@cortinico
Copy link
Contributor

@cortinico cortinico commented Jan 5, 2026

Summary:

This PR enables the hermesV1Enabled flag by default for Android.
Users will still be able to turn off the flag if they wish to revert to legacy Hermes.

Changelog:

[ANDROID] [CHANGED] - Enable hermesV1Enabled by default on Android, which turns on Hermes V1 (Static Hermes) by default

Test Plan:

CI

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 5, 2026
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Job Summary for Gradle

Test All :: run_fantom_tests
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
react-native-github :private:react-native-fantom:buildFantomTester 9.0.0 ❌ Build Scan not published

@cipolleschi
Copy link
Contributor

cipolleschi commented Jan 5, 2026

is this automatically download the right version of Hermes? because I think you also need the changes I have on #54989 where we update the version.properties file

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Job Summary for Gradle

Test All :: build_android
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
react-native-github publishAllToMavenTempLocal build 9.0.0 ❌ Build Scan not published

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Job Summary for Gradle

Test All :: run_fantom_tests
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
react-native-github :private:react-native-fantom:buildFantomTester 9.0.0 ❌ Build Scan not published

@meta-codesync
Copy link

meta-codesync bot commented Jan 5, 2026

@cortinico has imported this pull request. If you are a Meta employee, you can view this in D90129971.

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Job Summary for Gradle

Test All :: run_fantom_tests
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
react-native-github :private:react-native-fantom:buildFantomTester 9.0.0 ❌ Build Scan not published

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Job Summary for Gradle

Test All :: run_fantom_tests
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
react-native-github :private:react-native-fantom:buildFantomTester 9.0.0 ❌ Build Scan not published

@cortinico
Copy link
Contributor Author

cortinico commented Jan 7, 2026

Closing as this has been picked inside:

@cortinico cortinico closed this Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huntie huntie huntie approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cortinico @cipolleschi @huntie @facebook-github-bot